search

biosimulators / Biosimulators_COPASI

COPASI biochemical network simulation program via BioSimulators-compliant command-line interface and Docker container
https://docs.biosimulators.org/Biosimulators_COPASI
MIT License
2 stars 3 forks source link

Changed log level of Capturer Object #67

Closed AlexPatrie closed 1 year ago

AlexPatrie commented 1 year ago

What does this pr do? Addresses an issue related to this specific repo and others, as per #56. The log_level in method is by default set to StandardOutputErrorCapturerLevel.c which is "c". This results in a lack of proper output and a capture freeze. when setting this log_level to .python, a perfect output is produced in a timely fashion.

AlexPatrie commented 1 year ago

Working on a generalization now!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jcschaff commented 1 year ago

seems that the try: except: block to catch an assertion is unexpected - is there a reason that an if or if/else could not have been used? Generally using try/except for normal flow of control is not best practice in most languages. If this is in response to SonarCloud - then we need to address that.