biosimulators / Biosimulators_COPASI

COPASI biochemical network simulation program via BioSimulators-compliant command-line interface and Docker container
https://docs.biosimulators.org/Biosimulators_COPASI
MIT License
2 stars 3 forks source link

Biosimulators copasi gives incorrect results that normal copasi doesn't #71

Closed luciansmith closed 1 year ago

luciansmith commented 1 year ago

The attached OMEX files all produce different results on copasi-on-biosimulations than they do for copasi-on-my-desktop (or, for that matter, from tellurium-on-biosimulations).

BIOMD0000000005.omex.zip BIOMD0000000006.omex.zip BIOMD0000000007.omex.zip

The phenotype is the same for all: a value that should change in time instead is fixed and doesn't change. For Biomodels 5, the variable in question is YT, aka 'total_cyclin'. You can see the difference in

https://run.biosimulations.org/runs/64406c7ad5954382281dde42#tab=viz (copasi, incorrect) vs https://run.biosimulations.org/runs/64669bea9a62a8be53f457d1#tab=viz (tellurium, correct, and matches my copy of copasi, v4.36)

Biomodels 6: https://run.biosimulations.org/runs/64406c7a44d76b2ce805707f#tab=viz https://run.biosimulations.org/runs/64669bea49c0d898ffdaa536#tab=viz

Biomodels 7: https://run.biosimulations.org/runs/64406c7be039ed31faa8dc62#tab=viz https://run.biosimulations.org/runs/64669beb0dcacb5567885fc0#tab=viz

luciansmith commented 1 year ago

@fbergmann : Just in case you have an idea of how someone might accidentally tell Copasi to leave something fixed.

fbergmann commented 1 year ago

I think the biosimulator_copasi does use the utils to apply changes, rather than let COPASI do it. So the error would have to be fixed there, as it would apply to more biosimulators.

luciansmith commented 1 year ago

This is now fixed!