Closed luciansmith closed 2 years ago
Merging #104 (26b9c39) into dev (4403922) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #104 +/- ##
==========================================
- Coverage 97.11% 97.06% -0.05%
==========================================
Files 87 87
Lines 9139 10089 +950
==========================================
+ Hits 8875 9793 +918
- Misses 264 296 +32
Flag | Coverage Δ | |
---|---|---|
unittests | 97.06% <100.00%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
biosimulators_utils/combine/data_model.py | 100.00% <100.00%> (ø) |
|
biosimulators_utils/model_lang/xpp/utils.py | 82.70% <0.00%> (-4.48%) |
:arrow_down: |
biosimulators_utils/omex_meta/data_model.py | 100.00% <0.00%> (ø) |
|
biosimulators_utils/sedml/io.py | 99.51% <0.00%> (+0.39%) |
:arrow_up: |
biosimulators_utils/omex_meta/io.py | 96.42% <0.00%> (+0.85%) |
:arrow_up: |
biosimulators_utils/model_lang/xpp/validation.py | 89.54% <0.00%> (+2.60%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b50801...26b9c39. Read the comment docs.
@jonrkarr : Can we merge this? I need this one to run the latest temp_biomodels github actions, since we've renamed '.xpp' to '.ode', and need to create appropriate combine archive index files from them. Thanks!
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
2 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
I don't have strong preferences for these URIs because I'd prefer to see them all replaced by URIs for EDAM terms, as these aren't registered or commonly recognized media types. Unfortunately, that's still waiting on the EDAM developers to approve my PRs.
This would break what the XPP interface is set up to recognize. I added something on top to avoid needing to change the archives we already have. Basically, this allows ode
or xpp
to be used interchangeably in URIs. For example, ModelDB mainly uses the ode
extension, but sometimes uses xpp
.
@luciansmith does this look good to you?
That works for me! I just needed something to work with files named [x].ode, since that's what we renamed everything to.
@jonrkarr : Can you release a version of biosimulators_utils that has this change in it? I need it to run the latest temp_biomodels. Thanks! (The other change just reduces the warnings; it would be nice, but doesn't block anything like this does.)
This should be released at 0.1.169 in a few minutes.
The release protocol is:
biosimulators_utils/_version.py
The last step will trigger a GitHub action to create a new GitHub release and push a new version to PyPI.
We renamed all .xpp files to .ode in the biomodels project, so we need to now recognize those files.