biosimulators / Biosimulators_utils

Utilities for building standardized command-line interfaces for biosimulation software packages
https://docs.biosimulators.org/Biosimulators_utils
MIT License
4 stars 6 forks source link

fix (cellml): use integers for the number of steps #107

Closed bilalshaikh42 closed 2 years ago

bilalshaikh42 commented 2 years ago

What bugs does this PR fix?

Uses integers for the number of steps in a UniformTimeCourse to prevent underlying libSedML from raising type error. (closes #106) How have you tested this PR? Used the method to generate SED-ML files

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #107 (1c0f11b) into dev (2171183) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #107   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          87       87           
  Lines        9321     9321           
=======================================
  Hits         9006     9006           
  Misses        315      315           
Flag Coverage Δ
unittests 96.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
biosimulators_utils/model_lang/cellml/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e34df49...1c0f11b. Read the comment docs.