search

biosimulators / Biosimulators_utils

Utilities for building standardized command-line interfaces for biosimulation software packages
https://docs.biosimulators.org/Biosimulators_utils
MIT License
4 stars 6 forks source link

Allow element math to have attribute "id" in CellML files #108

Closed bilalshaikh42 closed 2 years ago

bilalshaikh42 commented 2 years ago

Many of the cellML files in the physiome repository fail validation because the "Math" elements contains "id" attributes. The model file fail validation with the message 117.0: Invalid attribute id for element math

@jonrkarr Is this something that we could change to a warning, or would you recommend that this be handled by physiome?

bilalshaikh42 commented 2 years ago

Looking closer at how validation is actually performed, it seems that this is something that the physiome models should correct since the math elements are defined with the MathML schema which is linked from the CellML schema https://github.com/biosimulators/Biosimulators_utils/blob/dev/biosimulators_utils/model_lang/cellml/cellml1.0.rng

jonrkarr commented 2 years ago

These errors are determined by CellML's own validation. Please submit GutHub issues for these issues to the Physiome repository.

jonrkarr commented 2 years ago

The schema that you linked is simply copied from cellml.org.

bilalshaikh42 commented 2 years ago

Closing as this should be fixed in physiome/cellml