Generalized macOS stdout handler in `Config` - Githubissues

biosimulators / Biosimulators_utils

Utilities for building standardized command-line interfaces for biosimulation software packages

https://docs.biosimulators.org/Biosimulators_utils

MIT License

4 stars 6 forks source link

Generalized macOS stdout handler in `Config` #137

Open AlexPatrie opened 1 year ago

AlexPatrie commented 1 year ago

What new features does this PR implement? Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

Adds Optional default setting for StandardOutputCapturerLevel to Config object through a validation block. Adjusted default setting from "c" to "python" (resolves https://github.com/biosimulators/Biosimulators_utils/issues/135)
Adds type annotations to functions

What bugs does this PR fix? Please summarize the bugs that this PR fixes. As relevant, please indicate the issues that the PR closes.

Fixes frozen stdout and no-output issues like https://github.com/biosimulators/Biosimulators_COPASI/issues/56

How have you tested this PR? Pytest, and self testing.

eagmon commented 1 year ago

I left some comments, this is looking pretty close. What's failing in the CI?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

AlexPatrie commented 1 year ago

I left some comments, this is looking pretty close. What's failing in the CI?

I just need to take care of some linting errors in this case.