Update simulation.py to use solution.objective_value vs. legacy solution.f

biosustain / cameo

cameo - computer aided metabolic engineering & optimization

http://cameo.bio

Apache License 2.0

114 stars 44 forks source link

Update simulation.py to use solution.objective_value vs. legacy solution.f #218

Closed jlerman44 closed 5 years ago

jlerman44 commented 5 years ago

Update simulation.py to use solution.objective_value vs. legacy solution.f

Tested lightly

phantomas1234 commented 5 years ago

Hi @jlerman44, thanks for contributing! Could you run flake8 . (pip install flake8 if you don't have it yet) in the cameo directory of your fork? Maybe it is just an overlong line?

jlerman44 commented 5 years ago

Oh yes. Let me do that! Sorry, i put in a quick fix using github's code editor. Did not have my linter on!

jlerman44 commented 5 years ago

flake8 simulation.py gives no warnings now

phantomas1234 commented 5 years ago

I'll check the broken build tomorrow, I don't quite remember if we ever got around making travis-ci builds work with forks. The problem was that we're installing cplex in the build which we can only do for the main repo.