search

biosustain / cameo

cameo - computer aided metabolic engineering & optimization
http://cameo.bio
Apache License 2.0
114 stars 44 forks source link

Update analysis.py #259

Closed matthiaskoenig closed 4 years ago

matthiaskoenig commented 4 years ago

Incorrect return type documented which is confusing for usage.

matthiaskoenig commented 4 years ago

Basically, I pulled the latest upstream changes in my fork and rebased against devel. I hope this is what you meant.

carrascomj commented 4 years ago

flake8 failed with an E501: line too long.

codecov[bot] commented 4 years ago

Codecov Report

Merging #259 (7966310) into devel (4ae0cdb) will decrease coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #259      +/-   ##
==========================================
- Coverage   62.45%   62.41%   -0.04%     
==========================================
  Files          56       56              
  Lines        5109     5109              
  Branches      891      891              
==========================================
- Hits         3191     3189       -2     
- Misses       1730     1732       +2     
  Partials      188      188
Impacted Files Coverage Δ
cameo/flux_analysis/analysis.py 72.96% <ø> (ø)
cameo/core/target.py 61.16% <0.00%> (-0.65%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ae0cdb...7966310. Read the comment docs.

phantomas1234 commented 4 years ago

Thanks @matthiaskoenig!