search

biot / en7523

Other
0 stars 1 forks source link

Mainlining of the spi driver #1

Open merbanan opened 2 years ago

merbanan commented 2 years ago

Are there any plans on mainlining the spi driver?

biot commented 2 years ago

Not by me. Talk to John Crispin or Felix Fietkau.

merbanan commented 2 years ago

Just for the record. This driver does not work well on mips devices. Maybe something with switch of manual and auto mode of the spi hardware. It causes UBI corruptions easily. The same issue could be present on the arm based platform. But we have other driver code that seems to work well:

https://dev.iopsys.eu/econet/linux/-/commit/8753c308493f120c80ad29a95195a6ec6abc01cd

biot commented 2 years ago

I am soon getting en7523 hardware again, and will be working on mainlining this driver after all, and I'd really like to dig into this issue. However your repo seems to have gone private since you posted this. Can you please check?

I've requested access on the gitlab instance, but received no response.

merbanan commented 2 years ago

I will make sure you get access to recent sources.

biot commented 2 years ago

Can you tell me a bit more about what platform you saw this problem on, and what you saw go wrong exactly?

merbanan commented 2 years ago

c13bbd3f54d8857e75004848f8b405b92002e300.txt

merbanan commented 2 years ago

The author of the spi driver changes observed this on mips hardware. What he observed I do not know. The arm platform was not affected and now we are running with dma support so it should just be considered as a rumor.