Open colleenXu opened 1 year ago
Also a consideration: do pending APIs (and Multiomics / Text-mining ones) need to keep both a ontology-specific field (where the value is probably not prefixed) and a general "ID" field for nodes?
Like here (the id vs HP field):
"object": {
"HP": "0000360",
"id": "HP:0000360",
"name": "Tinnitus",
"type": "biolink:PhenotypicFeature"
}
CC @tokebe @andrewsu @newgene
BTE previously automatically added the prefix to RHEA IDs, and at some point, stopped (this is the confusing part!)
I only noticed today while checking on another issue (primary knowledge source). And I tested / made this commit to add the needed prefix for operations using RHEA IDs as input: https://github.com/NCATS-Tangerine/translator-api-registry/commit/d78fd517fa39ac8bb0621af73a5a05f4d93cae15
I don't know the scope of this issue without doing a review of all the x-bte operations...my own musings below:
Noticed issue with GO prefixes and fixed by ensuring prefix is added to sub-queries https://github.com/NCATS-Tangerine/translator-api-registry/commit/370311917f650c3261cabb0c7c3553096c978a15
Noticed issue with MP prefix and fixed by ensuring prefix is added to sub-queries https://github.com/NCATS-Tangerine/translator-api-registry/commit/72748a184a33d9a823a2f6b7752c9401ed6727e6
BTE currently:
This can easily lead to bugs and is confusing. With the current big code update, it's not clear if there are some bugs / unexpected behavior with ID-prefixes....which prompted the discussion + writing this issue.
2023-03-22 discussions in group meeting and afterwards:
queryInputs
), BTE should remove the prefix from all ID-namespaces (rather than keeping prefixes for some)Seems like a design decision between @tokebe and me, although @andrewsu and @newgene can weigh in.
Notes: