Open colleenXu opened 1 month ago
Retriever has already been adjusted since it doesn't do scoring. This shouldn't be too involved to patch quickly, so I guess it's a matter of what the TRAPI group says.
We should change this to lookup
, according to Eric Deutsch (TRAPI group, Translator Slack link).
While it doesn't seem to matter much, I imagine we don't want to push the use of lookup_and_score
to Prod....so we'll want to make changes + deploy them up to Test in the next week or so? @tokebe
See https://github.com/biothings/bte-server/compare/c5aecdd860e4...397d8ac49567
Not sure of its deployment status right now
I double-checked and this is deployed on CI right now. But we want this to be deployed to all instances as a fix...
@andrewsu @tokebe (Follow up on Andrew's Slack thread)
According to the current TRAPI spec, the
/meta_knowledge_graph
MetaEdges can only have the valueslookup
and/orinferred
in theirknowledge_types
array.But in the code we're deploying to address https://github.com/biothings/biothings_explorer/issues/485, we changed BTE-ARA's
/meta_knowledge_graph
response to uselookup_and_score
(which is technically correct!). Note that the team-specific / api-specific endpoints still uselookup
.So....there's a question of what to do next:
lookup
for BTE-ARA's/meta_knowledge_graph
endpoint? (Does this involve changing the SmartAPI yamls?)