search

biothings / biothings_explorer

TRAPI service for BioThings Explorer
https://explorer.biothings.io
Apache License 2.0
10 stars 11 forks source link

update "regulates" x-bte operations #871

Closed colleenXu closed 1 week ago

colleenXu commented 1 month ago

The "regulates" data-modeling was recently changed with the merging of this PR https://github.com/biolink/biolink-model/pull/1491. We'd want to add qualifiers to these operations' qualifier sets.

I'm not sure when the changes need to be done by, but I imagine people want it done because these edges look odd in the UI: which was discussed in https://github.com/NCATSTranslator/Feedback/issues/744. That issue was closed before any changes were actually implemented...

Update: this was deployed in biolink model's 4.2.3 release.

To look at the latest data-modeling for "regulates"... See diff: latest biolink-model lines 9987-10034, predicate_mapping.yaml file

colleenXu commented 1 week ago

Turns out only BioThings GO BP (process regulates process) and Text-Mining Targeted (gene regulates gene) had operations to adjust.

I did this in a direct commit to the master branch. After SmartAPI registry's automatic refresh (at midnight Pacific?), ALL instances of BTE/Service Provider will be using these yamls.

So I think this issue can be closed.

Note: For BioThings GO BP's "process regulates process", I only added the qualified_predicate. I didn't add the suggested aspect (activity_or_abundance) because I didn't think that made sense for a process...