biothings / biothings_explorer_archived

BioThings Explorer: a schema-based client for API interoperability
Apache License 2.0
14 stars 14 forks source link

FindConnection parameters: issue and questions #115

Open colleenXu opened 4 years ago

colleenXu commented 4 years ago

A few related issues:

See https://github.com/colleenXu/biothings_explorer/blob/CX_WIPs_Here/jupyter%20notebooks/CX_WIPs/CX_WIP.ipynb for the code and output that demonstrate these issues.

1) The help for FindConnection() implies that the output_obj parameter can be a list of entities. However, I hit a Type Error when setting it to a list of strings or list of BioThings objects. TypeError: sequence item 0: expected str instance, list found

2) Currently, it looks like the intermediate_node parameter for FindConnection() cannot be a specific BioThings object (example: I can't put a specific disease as an intermediate node). This is specified in the help for FindConnection(). Is this behavior desired and wanted going forward?

  1. Currently, the input_obj parameter MUST be one specific BioThings object. This means BTE currently doesn't do gene / phenotype set queries. So if someone has an undiagnosed condition, one would have to do a query for each specific phenotype (multiple FindConnection objects) and then do post-processing to combine results. Is this behavior desired and wanted going forward?