biothings / biothings_studio

Pre-configured & ready-to-use BioThings API development environment
Apache License 2.0
4 stars 3 forks source link

Cannot create new builds with configuration containing dash (-) in its name. #4

Closed CristianoYL closed 6 years ago

CristianoYL commented 6 years ago

Issue description

When trying to create a new build, the process would fail if the configuration name contains a dash (-). The logs from the hub shows a 404:

WARNING:tornado.access:404 OPTIONS /build/my-test-config/new (172.17.0.1) 0.97ms

If we used underscore (_) instead, it would work.

Steps to reproduce

CristianoYL commented 6 years ago

Additionally, if the build name contains dashes(-), the similar error would occur when we try to manipulate it (e.g: deleting a build). The build would not get deleted, and the log shows similar 404:

WARNING:tornado.access:404 OPTIONS /build/test-new-build (172.17.0.1) 0.66ms
sirloon commented 6 years ago

fixed in https://github.com/biothings/biothings.api/commit/85b5c9a4ec1c9ada5f114081c6b567d159c35c24 will be deployed in release 0.1e https://github.com/biothings/biothings_studio/milestone/1