search

biothings / biothings_studio

Pre-configured & ready-to-use BioThings API development environment
Apache License 2.0
4 stars 3 forks source link

"Plugin already registered" but no datasource shown #6

Closed sirloon closed 6 years ago

sirloon commented 6 years ago

This happens when registration failed: it gives a mongo document/record, but the git folder is empty, no manifest.json.

In this situation, either the datasource should be shown in the app with an error, or the plugin should be unregistered automatically

sirloon commented 6 years ago

datasource needs to be shown in the, not unregistered as it would delete the source code and user may still have precious files...

sirloon commented 6 years ago

These commits should fix this issue, catching and propagating errors while loading an invalid plugin, while UI will show the error:

https://github.com/biothings/biothings.api/commit/ae9661bcb3119ed350d9ad0de8bd363773891ad9 https://github.com/biothings/biothings.api/commit/5f10f8530450d4cac804db74c53b36f8e5a97cdc