search

biothings / discovery-app

The Data Discovery Engine project by the CD2H Data working-group
http://discovery.biothings.io
Apache License 2.0
4 stars 9 forks source link

[bug] All custom validation rules don't seem to be save in the downloaded file #193

Open flaneuse opened 1 year ago

flaneuse commented 1 year ago

Describe the bug Weirdness with custom definitions! I created a bunch of new definitions; 4/5 of them appear in the Preview/Download.

To Reproduce Steps to reproduce the behavior: Create a new definition in the Schema Editor/Validator. Preview, then Download

Expected behavior All custom definitions should be included in the downloaded .jsonld

Screenshots I think it might be related to the fact that organization is only called within an array of anyOf?

Screen Shot 2022-09-16 at 4 39 29 PM Screen Shot 2022-09-16 at 4 39 44 PM Screen Shot 2022-09-16 at 4 40 44 PM
flaneuse commented 1 year ago

Ran into this issue again when making the Dataset schema -- even though it uses the same validation rules and reuses most of the properties, citation and organization definitions were missing in the download. It leads to a super annoying 500 error in the schema visualizer, which is hard to track down the source unless you know what you're looking for.