biothings / discovery-app

The Data Discovery Engine project by the CD2H Data working-group
http://discovery.biothings.io
Apache License 2.0
4 stars 12 forks source link

GitHub urls for json not getting resolved to raw json files #227

Closed gtsueng closed 1 year ago

gtsueng commented 1 year ago

Describe the bug I only consider this a bug because it wasn't an issue before. In the previous production version of the DDE, when you pasted a GitHub url of the JSON into the viewer, it would pop-up a clarification to use the raw version of the url (as opposed to the html version). This functionality doesn't appear to be working in the new DDE so the viewer will report an error when looking at something like https://github.com/gtsueng/specifications/blob/master/ChemicalSubstance/jsonld/ChemicalSubstance_v0.5-DRAFT.json instead of https://raw.githubusercontent.com/gtsueng/specifications/master/ChemicalSubstance/jsonld/ChemicalSubstance_v0.5-DRAFT.json

To Reproduce Steps to reproduce the behavior:

Expected behavior It should pop-up the GitHub url resolver/check dialog box as it did before

Screenshots If applicable, add screenshots to help explain your problem.

Additional context This is one of those features that get taken for granted. When it works, you don't notice it. When it doesn't, it can send the user into a spiral trying to correct a JSON file which is perfectly fine.

marcodarko commented 1 year ago

Will be fixed soon! A minor change to a library used and how a method should be called and was outdated caused a small bug. No major testing needed so pushing straight to prod and dev.

marcodarko commented 1 year ago

Fix deployed