search

biothings / discovery-app

The Data Discovery Engine project by the CD2H Data working-group
http://discovery.biothings.io
Apache License 2.0
4 stars 9 forks source link

Extensions including namespaces in DDE cannot be visualized in DDE #247

Closed ljgarcia closed 6 months ago

ljgarcia commented 6 months ago

Describe the bug Extensions including namespaces in DDE cannot be visualized in DDE, the interface gives an error "path to schema:Thing not found"

To Reproduce Extend from a DDE space, for instance maSMP and add some validation rules. Download the created file and add it to a GitHub repo, for instance https://raw.githubusercontent.com/ljgarcia/Deleteme/master/schemas/OutputMngPlanProfile.jsonld Try to visualize it with DDE playground

Expected behavior I would expect the file to be correctly loaded and visualized in DDE, instead I get an error

Screenshots image

Additional context Add any other context about the problem here.

marcodarko commented 6 months ago

@ljgarcia we noticed a small typo that could be cause in this schema: https://raw.githubusercontent.com/zbmed-semtec/maSMPs/main/schema/maSMP_schema_v2/maSMP_v2.jsonld

Screenshot 2024-01-18 at 10 17 34 AM

There's an extra colon "maSMP:" in the key name that effectively changes the name of the namespace so that could be the cause why the backend can't find a relation to the origin. If you can change that we can rule out this possibility but there's a good chance that's it because we took a look at the subclass and everything looked good there. Let me know if you have any questions!

ljgarcia commented 6 months ago

Oh! I would have not realize about it without your help, thanks a lot, it works now like charming! I will close this issue as "No Issue" with the option "Close as not planned" as there is nothing to fix on your side, hope this is fine. Thanks a lot!