search

biothings / discovery-app

The Data Discovery Engine project by the CD2H Data working-group
http://discovery.biothings.io
Apache License 2.0
4 stars 12 forks source link

Suggestion: allow the use of duplicate class names with warning #98

Closed gtsueng closed 3 years ago

gtsueng commented 3 years ago

Right now, a user cannot extend a class and give it the same name even if it will be saved to a different namespace. This is great for users creating their schema from scratch using the DDE, but not great for users porting their existing schemas into the DDE. If the schemas (such as Bioschemas) are already in use and already have the names they do, and blocking this functionality altogether creates more work in that the user must then do find/replace on the json file to rename a class. It's NOT prohibited when registering a schema, so it's strange for it to be completely blocked when creating one. Recommend having a pop-up explaining that using the same name as the original class may make it harder to find in the index, and then requesting confirmation to proceed. image

marcodarko commented 3 years ago

Addressed in this commit > https://github.com/biothings/discovery-app/commit/ef189229d4d39d423699905df1d91a201b3181bf