biothings / mydisease.info

7 stars 8 forks source link

Merge disease-variant records, similar to disease-gene records #32

Closed colleenXu closed 3 years ago

colleenXu commented 3 years ago

Main issue: After the discussion in today's biothings meeting, we agreed that these two endpoints, disgenet.genes_related_to_disease and disgenet.variants_related_to_disease, should have similar behavior. genes_related_to_disease has a step to merge records when all columns have the same value except pubmed that variants doesn't.

Also:

I plan to make a PR with edits for these issues. Then hopefully @kevinxin90 can check that it works and edit it if needed.

colleenXu commented 3 years ago

This issue has been addressed and is done. MyDisease does this now.