biothings / mydisease.info

7 stars 8 forks source link

Check CTD ingest for overwriting #59

Open colleenXu opened 4 months ago

colleenXu commented 4 months ago

(Discussed with @DylanWelzel 2/22)

It's potentially possible that the CTD data in MyDisease has missing info for reasons similar to #43.

The diseases can be MESH or OMIM IDs (or both? see https://ctdbase.org/detail.go?type=disease&acc=MESH%3AC000600608). There could be unique association data for the MESH ID vs the OMIM ID, and both map to the same mondo ID. In that situation, it's possible that the parser is overwriting data and the API only has data for 1 of the IDs (whichever is "later" during iteration).

I suspect that CTD may do some data-cleaning that mitigates this issue - putting their associations for a particular disease under the MESH ID whenever possible, and only using the OMIM ID when there's no MESH ID available. But I'm not sure since this was a note from several years ago.