biothings / mygeneset.info

Apache License 2.0
5 stars 3 forks source link

Allow empty genesets? #56

Closed ravila4 closed 1 year ago

ravila4 commented 1 year ago

There are 354 genesets with empty gene lists:

http://mygeneset.info/v1/query?q=count:0&facets=source

The counts by source are as follows: go: 190 ctd: 156 reactome: 6 msigdb: 1 smpdb: 1

The front end seems to be handling this well, it simply displays their metadata, and shows no genes.

Two questions arise:

  1. Is there any value in keeping empty genesets for curated sources? (My guess is probably not, in which case we can delete these.)
  2. Should we allow users to create empty genesets? (Have to check if the frontend handles this)
ravila4 commented 1 year ago

Update: the frontend displays empty user genesets correctly, and I think it is fine to allow users to create them.

As for empty curated genesets, I think that for now it is better to leave them, since genes that could not be found are displayed under the not_found field. In general, it's better to display information rather than hide it.