search

biothings / pending.api

Set of standalone APIs built with the BioThings SDK for the Translator Project
https://biothings.ncats.io
Apache License 2.0
5 stars 13 forks source link

UI: API page does not pick up the correct total count #252

Open newgene opened 1 week ago

newgene commented 1 week ago

In this new API page:

https://biothings.ci.transltr.io/annotator_extra

The total count appears as the first source's count, instead of the total count from the stats.total field.

This API is different from most of other APIs. It includes multiple sources in one API (most of others are typically a single-source API).

image
marcodarko commented 1 week ago

@newgene so is this like a special case or should ALL APIs do the same? I wanna ask before I make any changes just to make sure :)

newgene commented 1 week ago

You can confirm, I believe all API metadata should have the top-level stats.total.

newgene commented 1 week ago

but other metadata fields, like version, description, source etc., can be a special case for this API. Because it has three sources, instead of just one. We might a discussion to decide the best way to display them.

marcodarko commented 3 days ago

requested VPN access to tunnel the CI instance, so waiting on a response to get this working