biothings / smartapi-kg.js

A nodejs library for generate knowledge graphs based on SmartAPI Specifications
Apache License 2.0
0 stars 4 forks source link

Processing transformer field on operations #61

Open rjawesome opened 2 years ago

rjawesome commented 2 years ago

Helps solve https://github.com/biothings/BioThings_Explorer_TRAPI/issues/521 w/ https://github.com/biothings/api-respone-transform.js/pull/38

codecov[bot] commented 2 years ago

Codecov Report

Merging #61 (3d38e32) into main (874e120) will decrease coverage by 0.19%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   85.16%   84.98%   -0.19%     
==========================================
  Files          30       30              
  Lines         755      759       +4     
  Branches      164      163       -1     
==========================================
+ Hits          643      645       +2     
- Misses        111      113       +2     
  Partials        1        1              
Files Coverage Δ
..._builder/async_operations_builder_with_reasoner.ts 40.29% <ø> (ø)
...s_builder/sync_operations_builder_with_reasoner.ts 84.00% <ø> (ø)
src/parser/endpoint.ts 97.05% <100.00%> (ø)
src/parser/query_operation.ts 92.00% <50.00%> (-3.66%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rjawesome commented 2 years ago

TODO:

tokebe commented 1 year ago

@rjawesome Tests re-ran after I pushed a merge of the latest from main. There are definitely some failing tests. If this PR is required to support https://github.com/biothings/api-respone-transform.js/pull/38, please fix these tests and mark the PR as ready for review.

rjawesome commented 1 year ago

Tests are fixed (the X is for coverage not the tests)