biotite-dev / biotite

A comprehensive library for computational molecular biology
https://www.biotite-python.org
BSD 3-Clause "New" or "Revised" License
641 stars 101 forks source link

Fixed long locus ID issue in GB parser #583

Closed tcjaffe closed 3 months ago

tcjaffe commented 4 months ago

Also added support for missing linear/circular token like what we see in the GenBank sample file. Attempts to address the following issue:

https://github.com/biotite-dev/biotite/issues/486

padix-key commented 4 months ago

Thanks for the fix. Unfortunately, I am quite busy the next days, but I will review the PR next week.

tcjaffe commented 3 months ago

Thanks for implementing the fix. I have appended a few minor comments. If you like you, may also add yourself to CONTRIB.rst

Thank you! I'll apply the feedback and get an update PR up soon.

tcjaffe commented 3 months ago

Thanks again for the review, @padix-key . I think I made all the requested changes. Can you take another look when you have time?