search

biotite-dev / biotite

A comprehensive library for computational molecular biology
https://www.biotite-python.org
BSD 3-Clause "New" or "Revised" License
581 stars 92 forks source link

Fix `Atom` `__repr__()` (#602) #604

Closed ljarosch closed 1 week ago

ljarosch commented 2 weeks ago

This changes the hardcoded Atom __repr__() to a more general version that will additionally print custom added attributes.

EDIT: Fixes #602.

padix-key commented 2 weeks ago

The PR looks already good to me. Would you also like to add yourself to CONTRIB.rst? The PR is still in draft state: Is still still work in progress or ready to be merged?

padix-key commented 2 weeks ago

I linked the relevant issue in the PR description

ljarosch commented 2 weeks ago

I accidentally deleted the docstring for the __repr__ before, that's why I pulled it back to a draft. Would you prefer to have a new PR with cleaner commit history? Maybe a squash-merge would also work.

padix-key commented 1 week ago

I will simply squash-merge, no problem.

Would you prefer to have a new PR with cleaner commit history?

Just for your information: You can also force-push to a PR. Hence, you can locally cleanup the commit history and update the same PR with it using a force push.