Feature/react example - Githubissues

biotope / experimental-biotope-components

MIT License

2 stars 1 forks source link

Feature/react example #18

Closed ctmm closed 5 years ago

ctmm commented 5 years ago

React app POC:

Please remember to symlink the biotope package into the create react app POC before running the demo:

Build biotope package;
run yarn link;
cd into example/using-react and runyarn link biotope

Closes #2

ctmm commented 5 years ago

@jurekbarth (and everyone else):

The proposed implementation of overwriting logic works but I couldn't find a way to get it working as a HOC. You can't use refs with functional components.

Does anyone have input on how to achieve a more elegant solution?

ctmm commented 5 years ago

@jurekbarth @marwesfur @tiagomapmarques I may have reached an interesting solution for the hoc by means of forwardref. Please let me know your thoughts, when you find the time

SheepFromHeaven commented 5 years ago

Solves #2

timomayer commented 5 years ago

since it is an example implementation and not only a poc. shoudnt we update it @SheepFromHeaven?

SheepFromHeaven commented 5 years ago

@timomayer I agree, but not in this sprint. This is not a production ready critical issue. So I will create an issue and merge this PR