biotope / website

https://biotope.sh
MIT License
4 stars 0 forks source link

Use native elements for navigation #166

Closed vascocosta-vi closed 4 years ago

vascocosta-vi commented 4 years ago

Expected behavior

Anchors are used for navigation on the "Code & Resources", "Tutorials" and "See how" (footer) sections.

Actual behavior

Buttons are being used for navigation on those sections.

rhafner commented 4 years ago

Basically all button-tags that are used to navigate should be changed to anchor-tags. There are also buttons on the splash screen ("see how it works" + "see docs") and in the intro ("who's behind Biotope")

luke-m commented 4 years ago

Can you shortly elaborate why you think that should be done @vascocosta-vi ?

vascocosta-vi commented 4 years ago

Yes. Buttons are to send commands to the page (toggles, submit forms, perform actions. Links are for navigation. It also helps with getting the side indexed by web crawlers. Lastly, the current code is not working as expected: image

rhafner commented 4 years ago

Implemented