search

biovault / HDILib

HDILib is a library for the scalable analysis of large and high-dimensional data.
MIT License
6 stars 3 forks source link

knn_utils.h should be moved to dimensionality_reduction project #14

Closed jeggermont closed 7 months ago

jeggermont commented 4 years ago

knn_utils.h which contains enumerated types for KNN algorithms and KNN algorithm distance measures is currently in the utils project. However, the utils project has no information (e.g. defines) regarding supported KNN algorithms. This is currently all handled in the dimensionality_reduction project.

Moving knn_utils.h from the utils project to the dimensionality reduction project would make it a lot easier to add functions which return which KNN algorithm is supported and which distance measure is supported for which KNN algorithm.

It would be possible to add these functions in the dimensionality_reduction project but this leads to information regarding KNN algorithms to be split over several projects.

thoellt commented 4 years ago

I agree. Would you take this over?

jeggermont commented 4 years ago

Hi Thomas,

Yes I can prepare a branch. I was already working on a branch to add some support functions and moving the knn_utils can easily be part of it.

Jeroen

Leiden University Medical Center | Division of Image Processing (LKEB), Department of Radiology | PO Box 9600 | Postal zone C2-S | 2300 RC Leiden | The Netherlands

From: thoellt notifications@github.com Sent: Tuesday, 23 June, 2020 10:54 To: biovault/HDILib HDILib@noreply.github.com Cc: Eggermont, J. (RADI) J.Eggermont@lumc.nl; Author author@noreply.github.com Subject: Re: [biovault/HDILib] knn_utils.h should be moved to dimensionality_reduction project (#14)

I agree. Would you take this over?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/biovault/HDILib/issues/14#issuecomment-648006019, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRU4QCEWSFIVL5ZAJ3HUS3RYBURTANCNFSM4OE7QJYA.

alxvth commented 7 months ago

This was implemented in #16