biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

E_USER_DEPRECATED only avail in PHP 5.3+ #116

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. svn update to r705
2. use php < 5.3.0
3. witness warning thrown in class.corp.php

What is the expected output? What do you see instead?

Expected: no warning output
Received (from viewing a kill detail page):

WARNING [2] Invalid error type specified
Error on line 8 in file /var/www/virtual/kb.aperture-
ventures.com/common/includes/class.corp.php
PHP 5.2.11 (Linux), EDK 3.0.7 (Tyrannis)
File: /var/www/virtual/kb.aperture-ventures.com/common/includes/class.corp.php, 
line: 8, 
function: trigger_error
File: /var/www/virtual/kb.aperture-ventures.com/common/kill_detail.php, line: 
149, function: 
require_once
File: 
/var/www/virtual/kb.aperture-ventures.com/common/includes/class.pageAssembly.php
, 
line: 60, function: call_user_func
File: 
/var/www/virtual/kb.aperture-ventures.com/common/includes/class.pageAssembly.php
, 
line: 29, class: pageAssembly, function: call
File: /var/www/virtual/kb.aperture-ventures.com/common/kill_detail.php, line: 
1168, class: 
pageAssembly, function: assemble
File: /var/www/virtual/kb.aperture-ventures.com/common/index.php, line: 303, 
function: 
include
File: /var/www/virtual/kb.aperture-ventures.com/index.php, line: 25, function: 
include

What version of the board are you using? 

3.1 r705

What version of PHP and MySQL does the board run on?

PHP 5.2.11, MySQL 5.1

What is the url of a page where the error occurs or has occurred?

See above

Please provide any additional information below.

Probably ought to wrap the trigger_error() call in a version check and use 
E_USER_NOTICE or 
E_USER_WARNING on < 5.3.0

Original issue reported on code.google.com by twe...@gmail.com on 29 May 2010 at 2:06

GoogleCodeExporter commented 9 years ago
I did think I had tested this. Seems I was mistaken. I don't think it's worth 
writing 
extra code to throw E_USER_DEPRECATED just on 5.3 so I'll change them all to 
E_USER_NOTICE.

Original comment by kovellia on 29 May 2010 at 2:29

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r708.

Original comment by kovellia on 29 May 2010 at 2:34