search

biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

API mod broken possibly when reimporting deleted mails #119

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Not sure of the exact steps but I deleted two kills that weren't showing 
related details properly in 
trying to put together a bug report against that (I wanted to make sure it 
wasn't already 
addressed with the unknown/none changes recently) and reimported them via api 
mod and the 
results were the below. 

What is the expected output? What do you see instead?

Settings - API Mod V3.3
Settings Saved.
Downloading latest XML file for Ryel

API Killmail ID:12970108 successfully imported here as KB ID:-4
API Killmail ID:12970099 successfully imported here as KB ID:-4
2 kills, 0 malformed, 0 ignored and 0 verified from feed: Ryel which contained 
4 mails.

and the linked values point to 
http://kb.aperture-ventures.com/?a=kill_detail&kll_id=-4 and the 
two kills imported do not display.

Same behavior repeats with additional API loads.

What version of the board are you using? 

3.1 r709

The raw killmails in question (as copied from the client) can be downloaded 
from:

http://kb.aperture-ventures.com/kill1.txt
http://kb.aperture-ventures.com/kill2.txt

Original issue reported on code.google.com by twe...@gmail.com on 29 May 2010 at 3:37

GoogleCodeExporter commented 9 years ago 
Attempting to post them manually results in a message saying the kill had been 
deleted. So perhaps this is 
related to that work. If it's intended behavior then maybe one or more of the 
following behaviors should happen:

1) the API imports should override the deleted status 
2) the messaging in the API mode should be made more clear
3) the ability to completely remove a deleted kill from the database be added 
to allow the API to reimport/verify
4) the ability to undelete a deleted killmail be added

Original comment by twe...@gmail.com on 29 May 2010 at 3:42

GoogleCodeExporter commented 9 years ago 
Oops. Typo. 2) the messaging in the API mod should be made more clear.

Original comment by twe...@gmail.com on 29 May 2010 at 3:43

GoogleCodeExporter commented 9 years ago 
Deleted kills stay deleted now. Yes, the messaging in the api needs to be 
updated.

I'll add the choice of permanent deletion or temporary deletion. Undeleting is 
trickier 
since there's no existing thing to hook into so that will take longer.

To get them back now you will need to manually empty kb3_mails and reimport 
those two 
kills.

Original comment by kovellia on 29 May 2010 at 3:50

GoogleCodeExporter commented 9 years ago 
r714,r715 add the permanent/temporary delete options and an undelete for admins 
manually posting a mail.

Original comment by kovellia on 30 May 2010 at 3:25

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r720.

Original comment by kovellia on 30 May 2010 at 3:42