biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

kill_detail with no subsystems results in broken image tag #140

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. View a kill with no subsystems
2. Observe broken image tag referencing /img/panel/0s.png
3.

What is the expected output? What do you see instead?

in common/kill_detail.php if subcount = 0 then subc is assigned 0 in the smarty 
template.

in the smarty template themes/default/templates/kill_detail_fitting.tpl there 
is this code:

        <div id="subx" style="position:absolute; left: 0px; top: 0px; width: 398px; height: 398px; z-index:0;">
            <img src="{$img_url}/panel/{$subc}s.png" border="0"></div>

in this case /img/panel/0s.png doesn't exist so you end up with a broken image 
tag on kill details.

What version of the board are you using? 

3.1 r860

What version of PHP and MySQL does the board run on?

N/A

What is the url of a page where the error occurs or has occurred?

http://kb.aperture-ventures.com/?a=kill_detail&kll_id=31

Please provide any additional information below.

Original issue reported on code.google.com by twe...@gmail.com on 14 Jul 2010 at 12:59

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r861.

Original comment by Fried.Ro...@gmail.com on 14 Jul 2010 at 10:07

GoogleCodeExporter commented 9 years ago
I just forgot to add all of the 0 panels - they're basically blank icons. 
Nicely spotted.

Original comment by Fried.Ro...@gmail.com on 14 Jul 2010 at 10:08