biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

Incarnia: Non-existent images (pilot|alliance) are uncacheable atm. #150

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Clear cache
2. Refresh kb and you got many of nonexistent images on kb

Since Incarnia 1.1.0:
 Non-existent images {Alliance images with default icon and anonymous Pilot images) got redirected to: http{s}://image.eveonline.com/Alliance/1_{size}.png or http://image.eveonline.com/Character/1_{size}.png

Curl doesn't follow redirects, CURLOPT_FOLLOWLOCATION should be set to true, 
this solve the issue

What version of the board are you using? e.g. 3.0.5 or 3.1 revision 644

This is the EVE Development Network Killboard running version 3.1.5 (Tyrannis) 
rev Dev 1069

patch file is attached 

Original issue reported on code.google.com by kos...@gmail.com on 19 Jan 2011 at 2:56

Attachments:

GoogleCodeExporter commented 9 years ago
For pilots this doesn't help as the default image will be permanently stored, 
even if the avatar is created later. While also true for alliances, that's a 
much rarer issue.

I think that for now the current method is better as the images will only be 
created if they exist. When the new portraits are more common, it would be 
worth revisiting this. Of course, changing the error image to the default 
portrait image might look better in the short term.

Alternatively, what would CCP think of all EDK boards having the option of 
using CCP's image server directly? Instead of storing it locally, the browser 
is directed to CCP's server.

Original comment by kovellia on 20 Jan 2011 at 2:55

GoogleCodeExporter commented 9 years ago
Fixed in Revision 1152.

Original comment by kovellia on 31 Jan 2011 at 11:38