biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

cron_clearup.php doesn't re-enable page/query caching after script has completed #156

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enable page and query caching.
2. Run cron_clearup.php
3. Check admin page to find caching to be disabled.

What is the expected output? What do you see instead?
According to the comments in the code, it disables query caching while the 
script is running, but I'm not sure if the syntax for re-enabling is correct. 
Because it has to leave it disabled for people who had it disabled before the 
script ran, and enable it again if it was disabled by the script.

What version of the board are you using? 3.2.2 (Incursion) Build Dev 1319

Original issue reported on code.google.com by revi...@gmail.com on 10 Jul 2011 at 5:10

GoogleCodeExporter commented 9 years ago
I can't replicate your problem. Do you see any errors when the script runs? If 
it does not complete then the cache will not be reenabled.

Original comment by kovellia on 11 Jul 2011 at 3:21

GoogleCodeExporter commented 9 years ago
I actually had it scheduled to run through ajcron, and haven't run it manually. 
It would make sense that it never completes though. I ran it manually and it 
didn't return any errors. And it didn't leave the query caching settings 
disabled after it completed. With AJcron, I had the following entry for the 
script:

03:00 http://killboard.brick-squad.com/cron/cron_clearup.php [CleanUp]

And I guess it never completes or just hangs when cron is being utilized. Sorry 
for being to hasty on blaming the script. I will have look at this a little 
closer.

Original comment by revi...@gmail.com on 11 Jul 2011 at 6:39

GoogleCodeExporter commented 9 years ago
AJCron just has the browser run that script in the background. As far as the 
server is concerned it's identical. So it probably happens occasionally either 
way. It is odd for it to have timeouts, though. Removing files from disk is not 
that slow.

I'm marking as wontfix but if I find a way to speed it up I'll be doing it.

If you keep having the problem you could remove the cache disabling lines from 
the script. They are there because if parts of the cache are removed during the 
moment when another page is loaded, there may be errors shown on that page. You 
might prefer that happening sometimes to the cache being disabled at random, 
though.

Original comment by kovellia on 12 Jul 2011 at 4:24