search

biow0lf / evedev-kb

Automatically exported from code.google.com/p/evedev-kb
1 stars 0 forks source link

Git HEAD (102610b31c4be6cec4d381eee1b6c39ecdc4de61) kill posting problems #167

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Might be related to the work around on issue 166 (replacement on 
get_called_class for php 5.2)

When trying to post a kill I get (idfeed error at the bottom):

ERROR [256] Invalid mail
Error on line 612 in file 
/var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php
PHP 5.2.6-1+lenny13 (Linux), EDK 4.0.0 beta (Incursion)
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
612, function: trigger_error
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1634, class: Kill, function: getRawMail
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1342, class: Kill, function: getHash
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.parser.php, 
line: 723, class: Kill, function: add
File: /var/www/virtual/eve-co2.org/htdocs/common/post.php, line: 58, class: 
Parser, function: parse
File: /var/www/virtual/eve-co2.org/htdocs/common/post.php, line: 22, function: 
post
File: /var/www/virtual/eve-co2.org/htdocs/common/index.php, line: 290, 
function: include
File: /var/www/virtual/eve-co2.org/htdocs/index.php, line: 27, function: include

ERROR [256] Invalid mail
Error on line 612 in file 
/var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php
PHP 5.2.6-1+lenny13 (Linux), EDK 4.0.0 beta (Incursion)
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
612, function: trigger_error
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1634, class: Kill, function: getRawMail
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1364, class: Kill, function: getHash
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1346, class: Kill, function: realadd
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.parser.php, 
line: 723, class: Kill, function: add
File: /var/www/virtual/eve-co2.org/htdocs/common/post.php, line: 58, class: 
Parser, function: parse
File: /var/www/virtual/eve-co2.org/htdocs/common/post.php, line: 22, function: 
post
File: /var/www/virtual/eve-co2.org/htdocs/common/index.php, line: 290, 
function: include
File: /var/www/virtual/eve-co2.org/htdocs/index.php, line: 27, function: include

When trying to fetch kills via api or idfeeds I get errors like the one pasted 
bellow,

ERROR [256] Invalid mail
Error on line 612 in file 
/var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php
PHP 5.2.6-1+lenny13 (Linux), EDK 4.0.0 beta (Incursion)
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
612, function: trigger_error
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1634, class: Kill, function: getRawMail
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1342, class: Kill, function: getHash
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 452, class: Kill, function: add
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 393, class: IDFeed, function: processKill
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 126, class: IDFeed, function: processFeed
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 153, class: IDFeed, function: read
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 83, function: getIDFeed
File: /var/www/virtual/eve-co2.org/htdocs/common/index.php, line: 290, 
function: include
File: /var/www/virtual/eve-co2.org/htdocs/index.php, line: 27, function: include

ERROR [256] Invalid mail
Error on line 612 in file 
/var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php
PHP 5.2.6-1+lenny13 (Linux), EDK 4.0.0 beta (Incursion)
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
612, function: trigger_error
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1634, class: Kill, function: getRawMail
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1364, class: Kill, function: getHash
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.kill.php, line: 
1346, class: Kill, function: realadd
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 452, class: Kill, function: add
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 393, class: IDFeed, function: processKill
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 126, class: IDFeed, function: processFeed
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 153, class: IDFeed, function: read
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 83, function: getIDFeed
File: /var/www/virtual/eve-co2.org/htdocs/common/index.php, line: 290, 
function: include
File: /var/www/virtual/eve-co2.org/htdocs/index.php, line: 27, function: include

<row killID="0" killInternalID="157601" 

Snipped huge amount of idfeed content strings because of comment length limits.

 ["name:private"]=> string(12) "Triumvirate." ["imgurl:private"]=> string(57) "http://www.eve-co2.org/cache/img/Tr/iu/Triumvirate_32.png" } } ERROR [256] Kill not added.
Error on line 456 in file 
/var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php
PHP 5.2.6-1+lenny13 (Linux), EDK 4.0.0 beta (Incursion)
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 456, function: trigger_error
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 393, class: IDFeed, function: processKill
File: /var/www/virtual/eve-co2.org/htdocs/common/includes/class.idfeed.php, 
line: 126, class: IDFeed, function: processFeed
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 153, class: IDFeed, function: read
File: 
/var/www/virtual/eve-co2.org/htdocs/common/admin/admin_idfeedsyndication.php, 
line: 83, function: getIDFeed
File: /var/www/virtual/eve-co2.org/htdocs/common/index.php, line: 290, 
function: include
File: /var/www/virtual/eve-co2.org/htdocs/index.php, line: 27, function: include

Original issue reported on code.google.com by palmuves...@gmail.com on 7 Nov 2011 at 3:10

GoogleCodeExporter commented 9 years ago 
Actually that is caching error, turned of killmail and object caching and 
posting works

Original comment by palmuves...@gmail.com on 7 Nov 2011 at 3:11

GoogleCodeExporter commented 9 years ago 
Do the mails still post if you turn the object caching back on, and clear the 
cache?

Original comment by kovellia on 8 Nov 2011 at 11:30

GoogleCodeExporter commented 9 years ago 
No effect on clearing the cache, did little additional testing and the culprit 
seems to be the replacement get_called_class. One solution to this would be to 
mark the object caching as a php5.3 only feature, provide alternative stub for 
get_called_class for php5.2 platforms (since if I'm reading the code right 
get_called_class is only needed for enabling the object caching)

Original comment by palmuves...@gmail.com on 9 Nov 2011 at 2:08

GoogleCodeExporter commented 9 years ago 
I do like the Class::getByID($id) approach so I want to keep that. Mainly so 
caching is more efficient. new Class($id) is similar, but has to create a new 
object then copy variables across from the cache.

I may have to just make getByID() abstract and add a method to each class that 
extends Cacheable. It's a lot of repeated code, but not code that changes 
often. Nicer than a debug backtrace hack, too.

Original comment by kovellia on 9 Nov 2011 at 3:09

GoogleCodeExporter commented 9 years ago

Original comment by kovellia on 18 Dec 2011 at 2:53