pilot_detail.php comments/involved not showing on kill/loss filter.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open pilot detail, click between summary/kills/losses.

What is the expected output? What do you see instead?

I expect all tables to show comments/involved, not just summary.

What version of the board are you using? 4.0.1

Please provide any additional information below.

Look in function killList():

in the view switch, you will see the following lines under default, but NOT 
under kills and losses.

if (config::get('comments_count')) $list->setCountComments(true);
if (config::get('killlist_involved')) $list->setCountInvolved(true);

They should be in all of the cases, or none of the cases.  I prefer all, and 
recommend that option since they are switched from the admin panel anyways.

Original issue reported on code.google.com by jjl...@gmail.com on 14 Dec 2011 at 4:11

[GoogleCodeExporter]

I think on reflection that you're right about being there in all cases.

It also seems odd to set up a killlist with options fetched from the config, 
then pass that to the killlisttable which is what the config options are for. 
So, I'm trying to add this as an inherent part of the killlisttable. The 
downside is that without rewriting some of the core killlist code, 
KilllistTable must be passed the killlists before they are passed to 
pagesplitter. The need for this is not obvious so could easily cause problems.

Original comment by kovellia on 17 Dec 2011 at 3:12

• Changed state: Started
• Added labels: Milestone-Release4.1

[GoogleCodeExporter]

You are probably right regarding pushing config options as low as they can go 
on the execution tree, but it's a really low priority so I wouldn't sweat it.

Original comment by jjl...@gmail.com on 19 Dec 2011 at 1:49