[ ] Pull request details were added to CHANGELOG.md.
[ ] Documentation was updated (if required).
[ ] parameter_meta was added/updated (if required).
Rationale:
Git checks are now made "soft", by requesting it in the pull request checklist. This means you can update everything to develop, and then do not have to worry if 'develop' of your particular submodule was updated during the review. Very annoying. That is now fixed.
I do think the tagged check should remain for merges to master. So that still needs implementation.
Wdl-aid and womtool validate are quite slow. So only changed files are checked here. Miniwdl check is very fast, so that just checks everything.
Conda is now improved by caching. Design decisions:
The cache is invalidated every day. This means one environment install every day there are new PRs. This cost was deemed okay. The benefit is that we can change the test dependencies and have it work the next day.
Builtin-conda is used. Mamba does resolve and download the environment two times faster, but installing Mambaforge also takes time. Using builtin-conda takes no time. So in the case where we use the environment cache, builtin conda is much faster.
Environment is activated in a separate step as the setup miniconda action always seems to try and create a new environment instead of properly activating.
Checklist
parameter_metawas added/updated (if required).Rationale:
Git checks are now made "soft", by requesting it in the pull request checklist. This means you can update everything to develop, and then do not have to worry if 'develop' of your particular submodule was updated during the review. Very annoying. That is now fixed. I do think the tagged check should remain for merges to master. So that still needs implementation.
Wdl-aid and womtool validate are quite slow. So only changed files are checked here. Miniwdl check is very fast, so that just checks everything.
Conda is now improved by caching. Design decisions: