search

biox / pa

a simple password manager. encryption via age, written in portable posix shell
https://passwordass.org
Other
506 stars 21 forks source link

`contrib` scripts duplicate code #38

Closed apprehensions closed 3 months ago

apprehensions commented 3 months ago

dmenu, fuzzel, rofi, wmenu, and dmenu all share the same code. It is absolutely pointless to have all of the scripts be the same exact code, with the only diffrence being a binary name and arguments. They should all be merged into pa-dmenu, since all of the mentioned menu programs behave (and some are the same) as dmenu.

Other menu programs can be added in much easier, and maintaining these scripts become easier.

I would be willing to make a PR, however i use my own personal fork of pash and my own password menu script, being able to select properties of an entry.

arcxio commented 3 months ago

this has been discussed, see https://github.com/biox/pa/pull/19#issuecomment-2166968000

from my perspective, the scripts in contrib/ are meant to be standalone - [...] abstracting these into a single pa-menu script is too much - lots of folks just copy & paste the thing most relevant to them and the pa-menu abstraction complicates that a little too much for my liking. sorry!!

apprehensions commented 3 months ago

Lame.