search

bippisb / bipp-datasets

This Repository will have the code base for the datasets that are collected by BIPP
4 stars 7 forks source link

Daily Retail Price Report #60

Closed shravani1708 closed 2 months ago

vijaynyaya commented 8 months ago

Nice work, @shravani1708! You're off to a strong start. It's important to make commit messages descriptive of the work you've done. In this instance, you've created two commits with the messages 'commit 1' and 'commit message,' which aren't very informative. You could have named them 'initialize project retail_prices' and 'remove unnecessary files' for clarity.

Regarding the code in get_raw_data.py, the script relies on absolute paths that are specific to the computer where it's executed. It's advisable to use the data directory within the project's structure. You might want to explore using pathlib.Path for this purpose.

vijaynyaya commented 7 months ago

@shravani1708 We have only consolidated state wise data. The report also supplies India level figures such as Average Price, Modal Price, etc. A separate resource with only India level figures can be derived from the same raw data. Can you please create a script for it? It will look much like consolidate_state_wise_raw_data.py