search

biqqles / dataclassy

A fast and flexible reimplementation of data classes
https://pypi.org/project/dataclassy
Mozilla Public License 2.0
81 stars 9 forks source link

Fix some issues related to inheritance #27

Closed hroskes closed 3 years ago

hroskes commented 3 years ago

It now works if you inherit from DataClassMeta, and various combinations of having/not having __init__ defined also work.

biqqles commented 3 years ago

Very nice work, thanks, I'll review probably over the next couple of days.

hroskes commented 3 years ago

Thank you! I still find it a little weird to not follow the MRO, because now the inheritance behavior changes depending whether it's an annotation or not. But I think the current setup will be perfect for my code. Thanks again!

biqqles commented 3 years ago

Oh no, thank you for the fixes and tests!