search

biqqles / flint

A parser and API for Freelancer and its formats
https://github.com/biqqles/flint/wiki
Mozilla Public License 2.0
8 stars 2 forks source link

Get base news #15

Closed san-e closed 1 year ago

biqqles commented 1 year ago

Also sorry for the delay, I didn't see any notification from github about this.

biqqles commented 1 year ago

Thanks very much! Excellent implementation. I made some minor stylistic changes. The methods you added I renamed to have the underscore at the end, since this matches elsewhere (e.g. Base#system_ when names are taken by INI fields). I also used dataclassy.Internal to hide the bases attribute, since this is very long and makes the class neater to print.