search

biqqles / flint

A parser and API for Freelancer and its formats
https://github.com/biqqles/flint/wiki
Mozilla Public License 2.0
8 stars 2 forks source link

add mission_property to Ship() class #6

Closed san-e closed 2 years ago

biqqles commented 2 years ago

Hi, thanks for the PR. For this to be valid, the game must expect every [Ship] section to have a mission_property entry. Otherwise a mod that does not do this will cause an exception here. Have you verified this?

san-e commented 2 years ago

Hi, I've just tested this, and the game does indeed accept a [Ship] section without a mission_property entry. I have hopefully addressed this in the latest commit. (also, sorry for the cruise speed commits, I added those by accident to this PR)

biqqles commented 2 years ago

Thanks for testing that. The type should be Optional[str], but other than that, looks good.