birarda / logan

ruby gem to communicate with new Basecamp API
MIT License
16 stars 19 forks source link

lot's and lot's of stuffs #20

Closed stevenbristol closed 9 years ago

birarda commented 9 years ago

Sorry for delay on this - was disconnected for a bit on vacation. I'll take a look at your two PRs sometime this week.

Thanks!

stevenbristol commented 9 years ago

We moved dev on this from my repo to LessEverything's repo.

birarda commented 9 years ago

Gotcha - so I can close #19 and just look at this one, right?

stevenbristol commented 9 years ago

Yeah. :)

Wishing you happiness, Steven Bristol Founder of LessAccounting http://bit.ly/lessacc

On Mon, Apr 13, 2015 at 11:53 AM, Stephen Birarda notifications@github.com wrote:

Gotcha - so I can close #19 https://github.com/birarda/logan/pull/19 and just look at this one, right?

— Reply to this email directly or view it on GitHub https://github.com/birarda/logan/pull/20#issuecomment-92409426.

AvaelKross commented 9 years ago

+

birarda commented 9 years ago

Out of curiosity, what was activesupport needed for in that?

Nevermind, I see now that was the constantize inflector.

stevenbristol commented 9 years ago

.blank?

Wishing you happiness, Steven Bristol Founder of LessAccounting http://bit.ly/lessacc

On Wed, May 20, 2015 at 12:57 PM, Stephen Birarda notifications@github.com wrote:

out of curiosity, what was activesupport needed for in that?

— Reply to this email directly or view it on GitHub https://github.com/birarda/logan/pull/20#issuecomment-103958309.

birarda commented 9 years ago

Got it, thanks. Would rather not require activesupport if we don't need to so I replaced that with nil? and then empty?