birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
605 stars 45 forks source link

[Bug] [Edge] Can no longer enable 10ten add-on #1001

Open yesimanoob opened 2 years ago

yesimanoob commented 2 years ago

I have 10ten version 1.12.5 installed through the Microsoft Store running on Edge version 105.0.1343.42 (64-bit) on Windows 11, and I haven't been able to activate the extension in quite a while (at least a month). Clicking the extension button in the browser bar no longer works, nor does right-clicking on it and selecting "Enable 10ten reader."

It used to work in edge just fine but hasn't for a while now. I hope this gets fixed because as-is the extension is useless. :(

Thank you!

yesimanoob commented 2 years ago

I tested on a Win10 laptop I have with Edge Version 105.0.1343.53 (64-bit) and 10ten version 1.12.5 and the enable/disable switch is working.

birtles commented 2 years ago

Hi! Sorry 10ten is not working for you. I'm currently travelling without my computer so I can only provide a couple of guesses but I wonder if perhaps the settings have been changed so that it requires Ctrl key, for example to be pressed in order for the popup to be shown?

Otherwise, I wonder if deleting and reinstalling the extension might help?

Once I get back to the office I hope I can give some more helpful suggestions. Until then, sorry for the inconvenience!

yesimanoob commented 2 years ago

Thank you for the message. No worries about inconvenience - am happy to benefit for your generous work.

I updated Edge to Version 106.0.1370.37 on my Windows 11 machine (first post) and am able to enable/disable 10ten as expected. I wonder what the issue was.

For what it's worth, I noticed a few other people complaining about a similar issue in the reviews on the Microsoft Store.

yesimanoob commented 2 years ago

Nope, it's broken again. Not sure what happened.

birtles commented 2 years ago

Hi, I'm sorry to hear its misbehaving again. It seems to be working here but I notice one other person (Faye) on the Microsoft Store is complaining of similar symptoms.

I wonder if you might be able to try the following steps for me:

  1. Right-click on the icon in the toolbar and choose "Extension options"
  2. Close the (tiny) options window that appears
  3. Find the row that says "Inspect views" and click "Background page"
  4. Go to the "Console" tab and copy and paste any errors you see there.

Some of the labels might be slightly different (I'm using the Japanese version of Edge so I'm not entirely sure what the English version says). Also, it's possible the "Inspect views" item might not be shown without enabling developer mode for extensions.

Also, when you say that clicking the button in the toolbar no longer works, does that mean that the button itself doesn't change between being black vs gray?

yesimanoob commented 2 years ago

Correct: the button color doesn't change when clicked.

Here is what I see when I first open the console issues tab: image

Hopefully that helps.

birtles commented 2 years ago

Thank you! Would you be able to send a screenshot of the Console tab? (Next to the Issued tab)

yesimanoob commented 2 years ago

It was empty.

Edit: I think console is for the user to type commands in to, so I wouldn't expect anything to show there unless a command was first entered?

image image

birtles commented 2 years ago

The console will show errors/warnings/diagnostics. When nothing is wrong, it will often show at least the latest dictionary download.

image

Given that there's nothing in the console for you, that suggests that either (a) the extension is not running at all, or (b) the extension is running but it decided the database was already up-to-date.

Thanks for all your help on this. I don't have any theory yet as to what is going wrong but it would really help if you could answer the following three questions:

  1. When the 10ten button doesn't respond (doesn't change color), what color is it? The enabled color (i.e. black background) or the disabled color (i.e. grey background)? Alternatively, if you can send a screenshot of the button that would be fine too.
  2. If you press the button and then try highlighting over Japanese text, does it work anyway? (You might need to try pressing it several times in case it was already enabled).
  3. Does the extension fail to work on all sites? e.g. can you try using it on asahi.com or yahoo.co.jp for example?

I'm trying to determine if just the button is broken or if the extension is somehow disabled.

I recently helped one person debug an issue where the cause was an enterprise policy blocking all extensions on Google properties.

Thanks for your patience in working through this.

yesimanoob commented 2 years ago
  1. The button color is always gray/disabled.
  2. No, it doesn't work if I press the button even without an icon background change. Further, even after pressing the button, then inspecting the button's right-click menu there is no check mark next to the "Enable 10ten reader" menu item. Further, if I select that menu item its state doesn't change: the extension doesn't activate, and the check mark doesn't appear next to the menu item.
  3. I haven't been able to get it to work on any Japanese sites or text.
  4. This is on my personal computer, so no corporate policies ought to be in effect.
yesimanoob commented 2 years ago

I tried spamming the buttons for a while and noticed this behavior:

It seems that there are 2 issues:

  1. The extension's state isn't correctly updating
  2. The extension won't enable without a page reload
birtles commented 2 years ago

Thank you that's very helpful.

I don't seem to be getting any related automated error reports from Edge, unfortunately. It appears to be in some sort of bizarre state that I haven't heard of on other browsers either.

I think my next step is to try to audit the code for updating the toolbar button to see if there is anything possibly amiss there, or at least add some more logging there.

At this stage my best guess is another extension or even virus software is interfering. I don't suppose there are any other extensions or virus software you can disable to eliminate the possibility that they might be interfering?

birtles commented 2 years ago

I've dug into the code and tried various experiments here but as of yet I can't reproduce the problem I'm afraid.

If you have any hints about when the extension works versus when it doesn't work that would help. Otherwise I'm inclined to suspect another extension or setting or program could be interfering.

yesimanoob commented 2 years ago

I've only got uBlock Origin and Bitwarden extensions enabled -- but this is the same as on the Windows 10 machine which seems to be working fine (for now).

I tried rikaikun and its status icon updates as expected but it also has the "need to refresh before popups appear" issue.

yesimanoob commented 2 years ago

Is the error from the "Issues" tab I shared before not a problem? ("Viewport meta element was not specified")

birtles commented 2 years ago

I've only got uBlock Origin and Bitwarden extensions enabled -- but this is the same as on the Windows 10 machine which seems to be working fine (for now).

Ok, thanks. I'm testing on Windows 11 and it's working fine here so I don't think it's related to the Windows version.

I tried rikaikun and its status icon updates as expected but it also has the "need to refresh before popups appear" issue.

Oh, that's very interesting. That suggests that something else is interfering, as opposed to a bug in 10ten itself.

Is the error from the "Issues" tab I shared before not a problem? ("Viewport meta element was not specified")

Yes, it's fine. That only affects pages intended to be displayed on mobile phones. The page in this case is the extension background page which is never displayed.

I've tried searching for reports of similar issues but I can't find any. I wonder if it's possible to create a new profile for Edge and try there?