search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
610 stars 45 forks source link

-tari and -tara inflections #110

Closed toasted-nutbread closed 5 years ago

toasted-nutbread commented 5 years ago

I was recently updating some inflection data for https://github.com/FooSoft/yomichan/pull/199 and it was noticed that there are some rules which seem to be mixed up. Specifically, some of the -tari and -tara rules seem to be switched. For example, see 往ったら on lines 178 and 182 of: https://github.com/birtles/rikaichamp/blob/1467cf459c974b86889a39993ce469aa289f2ea2/src/deinflect.ts#L178-L182

Maybe because DeinflectReason.Tari was repeated twice on line 179 and 180, whereas it usually looks like it's alternating between DeinflectReason.Tara and DeinflectReason.Tari?

Anyway, not clear if this is on purpose or not. If it's a bug, I can create a PR to fix it if you like.

birtles commented 5 years ago

Yeah, that definitely looks like a bug!

birtles commented 5 years ago

Closed by 6cdd179811a0a0a183353aa9dcbfe69bbf1608e5