search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
599 stars 45 forks source link

10ten makes buttons not work on some websites #1144

Closed ghost closed 1 year ago

ghost commented 1 year ago

Using this extension on Chrome breaks random buttons in websites. I notice this a lot using Misskey and Pleroma frontend. The buttons just become unclickable when you are hovering them (they stop doing their hover animation, cursor doesn't turn to hand, clicking does nothing). Turning off 10ten fixes it.

It doesn't break the same buttons every time. But it happens often on random buttons. On Misskey it happens most of the time that entries in the context menus cannot be clicked. On PleromaFE it seems the "open in remote instance" button on the top right corner of a remote user's profile is prone to breaking while being hovered. It happens on other pages too sometimes but I can't remember specific examples.

Tested on Brave version 1.49.120, can't replicate in Firefox. Using Windows

birtles commented 1 year ago

Hi @dk3904!

Thank you for filing this issue. I'm sorry about the annoyance with those buttons.

I've spent the last two weeks completely rewriting how 10ten looks up text in Web pages and will (hopefully) submit the updated version to the Chrome Web store later today. That 🤞might🤞 fix it. If not, I will try to sign up for Misskey/PleromaFE to see if I can reproduce the issue. If you notice it on any other pages (that I don't need to sign up for) please let me know! Thank you!

ghost commented 1 year ago

You don't need to sign up to try it on Pleroma. You can view this page for example: https://clubcyberia.co/users/$A8hfz4gqdQKtg9AttI and on the top right corner there is an icon like this: image

You can just try hovering and clicking it. It could take a few page refreshes to trigger, but it doesn't usually take long. It seems to happen often when you are hovering it while the rest of the page is still loading. If while hovering you see the "click" cursor turn back to a regular pointer, you've triggered it.

Thank you for the work you do, this extension is amazing. I will test it when the update is out and report back if I can reproduce it.

ghost commented 1 year ago

I haven't been able to replicate this issue since updating to 1.14.0. I think this is solved.

birtles commented 1 year ago

Thanks for checking @dk3904! That's great news!