birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
585 stars 43 forks source link

Popup cancelling Figma sidepanel rename mode #1920

Open brainwo opened 1 month ago

brainwo commented 1 month ago

Not sure this should be extension feature or a browser feature, but it would be helpful if there is an option to specify "blacklisted sites". This will allow users to list domain/page where they don't want this extension to be enabled on.

I find it's annoying when I work using Figma and also in the same time need 10ten-ja-reader to be enabled in sites in which I copy some words from as hiragana.

Clicking on editable text makes difficult, I need few times to make it work. Disabling and enabling the extension via keyboard shortcut also isn't ideal.

2024-08-0912:25:34UTC_firefox mp4

Alternative solution I'm considering is to allow disabling words lookup in <input> element.

birtles commented 1 month ago

That certainly looks annoying to have it pop up there!

I haven't personally encountered that situation too much since I have 10ten always on and use Ctrl to enable it just when I want to look something up.

This setting here:

image

I think we could add a feature to disable 10ten for various sites, however we should probably do that as part of reworking how it gets enabled in general. For the Safari version we use activeTab mode which means it's only enabled on tabs the user explicitly enables it for. However, many Safari users find that annoying.

It would be nice if we can make it start off in activeTab mode and allow users to expand the permissions to all sites or select sites only (and potentially exclude sites at the same time).

Alternatively, if it's never useful to lookup Japanese text in the Figma sidebar, we could specifically make 10ten ignore that content.