search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
604 stars 45 forks source link

fix: prevent duplicate reasons in deinflection reason chains #2013

Closed enellis closed 1 month ago

enellis commented 1 month ago

Related to #1966.

Any reason chains containing duplicate reasons will now be discarded to avoid unreasonable matches.

enellis commented 1 month ago

Should we also add a unit test for this?

birtles commented 1 month ago

Should we also add a unit test for this?

Thank you! Yes, that would be great!

enellis commented 1 month ago

Should we also add a unit test for this?

Thank you! Yes, that would be great!

Done :)

birtles commented 1 month ago

Thank you!