search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
604 stars 45 forks source link

Pop up shows even when I set ctrl to be required (only for images) #2028

Closed gevhaz closed 1 month ago

gevhaz commented 1 month ago

Thanks for the plugin – it's been super useful for me. I think I found a bug. I have configured 10ten to require the control to be held down for the popup to show. This works for text. But still when I hover an image, I get the popup, which is obviously not supposed to happen.

birtles commented 1 month ago

Hi @gevhaz! Thank you!

If I understand the issue correctly, I think it might be a case of the settings panel being confusing. There are two rows for controlling the popup keys:

image

If you don't select any keys in the second row (for images), then the popup will show for images even when you don't press anything.

Is it possible you haven't selected "Ctrl" for the images row?

gevhaz commented 1 month ago

That's a very obvious setting now that you point it out :grin:

Thanks for your patient answer :) Resolving.