birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
604 stars 45 forks source link

If a word ends in 氏, parse the previous characters using the names dictionary first #484

Open nicolasmaia opened 3 years ago

nicolasmaia commented 3 years ago

This idea was prompted by the fact that Biden is in the news right now and rikai currently thinks it's looking at 売電. At the very least, バイデン氏 should ideally show the president's name.

Maybe other suffixes like 大統領 etc could trigger this behaviour as well.

SaltfishAmi commented 3 years ago

maybe a full identical katakana match in the names dict should take priority over the converted hiragana term in words dict?

Tomalak commented 3 years ago

...only when the input is Katakana, too. For ばいでん it should still do what it does right now.